[ 
https://issues.apache.org/jira/browse/SOLR-571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-571:
--------------------------

    Attachment: SOLR-571.patch

Tomas: thanks for taking a crack at this, your patch (particularly the tests) 
are much appreciated!

I'm not keen on proliferating the amount of cut/paste between LRUCache and 
FastLRUCache, so i refactored your new code into a baseclass.  i also felt 
uncomfortable overloading the same int value to be both a number and a 
percentage depending on the value of a different boolean, so i also refactored 
that into an immutable reference class that abstracts the logic.

revised patch attached, i'll commit as soon as i finish running all the tests

> LRUCache autowarmCount should support percentages
> -------------------------------------------------
>
>                 Key: SOLR-571
>                 URL: https://issues.apache.org/jira/browse/SOLR-571
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-571.patch, SOLR-571.patch
>
>
> a recent thread reminded me of an old idea that never got implemented...
> the autowarmCount for LRUCaches should support "percentages" which get 
> evaluated relative the current size of the cache when warming happens.  
> in this way, a Solr instance might be configured with autowarmCount="50%" to 
> autowarm the top half of the queries ... a master machine might be configured 
> this way to give some autowarming if it is inadvertently being queried, but 
> things won't be maintained in the caches in perpetuity ... each subsequent 
> cache instance would have fewer and fewer of the "old" queries warmed 
> automatically.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to