[ 
https://issues.apache.org/jira/browse/SOLR-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-1870:
---------------------------

    Attachment: SOLR-1870.patch

Based largely on *guessing* what it was that this Update codec was trying to 
do, i created this patch -- it's based on the theory that the "outermost" 
Iterator is expected to be the stream of documents, and any other Iterator 
should be parsed in the same way as the superclass.  It uses a simple boolean 
to keep track of whether or not the "first" (ie: outermost) Iterator has been 
encountered yet (which is only feasible because it's an anonymous inner class 
used for only one stream)

This patch causes all tests to pass -- but that doesn't necessarily convince me 
that it's correct -- i would definitely appreciate it if someone who has 
actually *looked* at the update codec code prior to today would review this.

(Note: i did have to modify the document equality assertions to understand that 
since we will never have a Set in an unmarshaled doc it needs to convert the 
corrisponding Collection to a set in order for assertEquals to do a non-ordered 
comparison)

> Binary Update Request (javabin) fails when the field type of a multivalued 
> SolrInputDocument field is a Set (or any type that is identified as an 
> instance of iterable) 
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-1870
>                 URL: https://issues.apache.org/jira/browse/SOLR-1870
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java, update
>    Affects Versions: 1.4
>            Reporter: Prasanna Ranganathan
>         Attachments: SOLR-1870-test.patch, SOLR-1870.patch
>
>
> When the field type of a field in a SolrInputDocument is a Collection based 
> on the Set interface, the JavaBinUpdate request fails. It works when sending 
> the document data over XML.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to