[ 
https://issues.apache.org/jira/browse/LUCENE-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869579#action_12869579
 ] 

Earwin Burrfoot commented on LUCENE-2471:
-----------------------------------------

The only reason for keeping that iteration within Directory was to reuse the 
buffer. The savings are neglectable, I think. 

bq. Copying an entire Directory is used by Lucene code only in RAMDir when it's 
init'ed w/ a Directory.
So what? :) I used copying an entire Directory for backup purporses, then 
switched to copyTo(collection), to cherry-pick a single commit.

Still I agree with switching to single file copy+rename. Back-compat luckily 
went out of the window, so we can design better APIs :)
Can we do this in a separate issue from LUCENE-2455 ?

> Supporting bulk copies in Directory
> -----------------------------------
>
>                 Key: LUCENE-2471
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2471
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Earwin Burrfoot
>
> A method can be added to IndexOutput that accepts IndexInput, and writes 
> bytes using it as a source.
> This should be used for bulk-merge cases (offhand - norms, docstores?). Some 
> Directories can then override default impl and skip intermediate buffers 
> (NIO, MMap, RAM?).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to