[
https://issues.apache.org/jira/browse/LUCENE-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873004#action_12873004
]
Michael McCandless commented on LUCENE-2481:
--------------------------------------------
This looks nice Shai!
So now you can keep any number of outstanding snapshots, and, if you
use PersistentSnapshotDeletionPolicy, you can keep these snapshots
alive across close/open of IndexWriter, right?
And, if one has some other way to persist snapshots (instead of using
a Lucene index as PersistentSnapshotDeletionPolicy does), one can
simply subclass SnapshotDeletionPolicy
Can you rename "String segment" -> "String segmentsFileName" (or
segmentsFile)? Ie, this is referring to the collection of segments
that make up a given commit? It's confusing to see "segment" all over
because it makes me think you're somehow doing something
per-segment...
> Enhance SnapshotDeletionPolicy to allow taking multiple snapshots
> -----------------------------------------------------------------
>
> Key: LUCENE-2481
> URL: https://issues.apache.org/jira/browse/LUCENE-2481
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2481-3x.patch
>
>
> A spin off from here:
> http://www.gossamer-threads.com/lists/lucene/java-dev/99161?do=post_view_threaded#99161
> I will:
> # Replace snapshot() with snapshot(String), so that one can name/identify the
> snapshot
> # Add some supporting methods, like release(String), getSnapshots() etc.
> # Some unit tests of course.
> This is mostly written already - I want to contribute it. I've also written a
> PersistentSDP, which persists the snapshots on stable storage (a Lucene index
> in this case) to support opening an IW with existing snapshots already, so
> they don't get deleted. If it's interesting, I can contribute it as well.
> Porting my patch to the new API. Should post it soon.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
