[ 
https://issues.apache.org/jira/browse/LUCENE-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874652#action_12874652
 ] 

Yonik Seeley commented on LUCENE-2485:
--------------------------------------

bq. If an application needs warming, it will need to warm up new segments 
exposed through getReader() anyway.

But it's very different... the advantage to warming new segments is that the 
warm step was considered part of the merge by getReader() - if the whole thing 
hadn't completed yet, getReader() would still immediately return with the old 
segments pre-merge.  w/o this ability, there's no advantage to warming in a 
hook vs warming explicitly after getReader().


> IndexWriter should also warm flushed segments
> ---------------------------------------------
>
>                 Key: LUCENE-2485
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2485
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael McCandless
>             Fix For: 4.0
>
>
> Spinoff of LUCENE-2311.
> You can now set a mergedSegmentWarmer on IW, which warms only newly merged 
> segments.
> But for consistency maybe we should change this to warm all new segments (ie, 
> also flushed ones).  We should rename it to something "setSegmentWarmer".
> Really, the reader pool should be pulled out of IndexWriter, be externally 
> provided, and be responsible for doing warming of new segments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to