[ 
https://issues.apache.org/jira/browse/LUCENE-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875887#action_12875887
 ] 

Michael McCandless commented on LUCENE-2488:
--------------------------------------------

This looks like a great step forward -- we can now [optionally; off by default] 
assert those modules (core, contribs) that "claim" to be <= JDK X in fact 
compile & pass tests with JDK X.

So we now default to a hard error.... but if you want (eg you are the RM), you 
can pass -Dforce.jdk14.build=true, and skip those contribs requiring > X.  I 
agree the default should be brittle (hard error).

Can we use this for Solr/Lucene on trunk/3x?  Ie Solr requires JDK >= 1.6, but 
Lucene is >= 1.5; we don't want 1.6 features to accidentally sneak into 
Lucene...

> Fix 2.9 contrib builds to succeed when JDK 1.4 is used (leaving out contribs 
> that require 1.5)
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2488
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2488
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 2.9, 2.9.1, 2.9.2
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.3
>
>         Attachments: LUCENE-2488.patch, LUCENE-2488.patch
>
>
> When you build and test Lucene 2.9 with Java 1.4, building and testing of 
> contrib fails. This patch fixes this to repect the current compiler version 
> and disables all contribs that need Java 1.5 by checking their javac.source 
> property.
> This patch can be ported to 3.x or trunk, when 1.6 contribs will appear.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to