[
https://issues.apache.org/jira/browse/SOLR-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878950#action_12878950
]
Mark Miller commented on SOLR-1953:
-----------------------------------
I've got to look at the code - but I wonder if this should be a shared instance
that is reused - the cleaner uses a thread that has a special call related to
shutting it down. I don't remember all of the specifics, and I have to look at
the commons code, but it may not make sense to use a new cleaner on every
object creation. Will post back.
> It may be possible for temporary files to accumulator until the Solr process
> is shut down
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-1953
> URL: https://issues.apache.org/jira/browse/SOLR-1953
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 1.4.1, 1.5
> Reporter: Karl Wright
> Attachments: SOLR-1953.patch
>
>
> While researching SOLR-1951, the behavior of commons-fileupload in handling
> multipart form posts came into question. commons-fileupload creates a
> temporary file for the main content area of such posts, and purportedly has a
> background thread which cleans up these files. However, Mark Miller
> discovered that the javadoc in this matter may be incorrect, and that
> commons-fileupload may in fact just be adding files to the JVM's list of
> files needing cleanup on exit.
> If so, this will show up in two ways: first, temporary files will accumulate
> in the java.io.tmpdir area. Second, non-heap memory for the JVM will slowly
> increase over time (since the file pointers the JVM tracks in this way are
> not kept in the java heap).
> I will attach a potential fix; however, this ticket should be viewed as a
> workitem for the need for further research in this area.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
