FieldComparator.TermOrdValComparator compares by value unnecessarily
--------------------------------------------------------------------

                 Key: LUCENE-2531
                 URL: https://issues.apache.org/jira/browse/LUCENE-2531
             Project: Lucene - Java
          Issue Type: Improvement
          Components: Search
            Reporter: Michael McCandless
            Priority: Minor
             Fix For: 3.1, 4.0


Digging on LUCENE-2504, I noticed that TermOrdValComparator's compareBottom 
method falls back on compare-by-value when it needn't.

Specifically, if we know the current bottom ord "matches" the current segment, 
we can skip the value comparison when the ords are the same (ie, return 0) 
because the ords are exactly comparable.

This is hurting string sort perf especially for optimized indices (and also 
unoptimized indices), and especially for highly redundant (not many unique 
values) fields.  This affects all releases >= 2.9.x, but trunk is likely more 
severely affected since looking up a value is more costly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to