[ 
https://issues.apache.org/jira/browse/SOLR-2002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated SOLR-2002:
------------------------------

    Attachment: SOLR-2002_core_contrib.patch

there is one single test in solr core that depends on contrib modules.
I am confused about this test, as it seems to already test the functionality 
with core code (CSV) only to then also test it with contrib code (PDF)
In my opinion: core tests shouldnt depend on contrib modules.

I propose either:
# applying this patch, and removing the dependency of core tests on contrib.
# if this functionality (extraction) is considered core, then it should be 
moved out of contrib.

Can someone take a look and give me their opinion? I think this would really 
start to make it easier to improve the build.

> improve build/tests
> -------------------
>
>                 Key: SOLR-2002
>                 URL: https://issues.apache.org/jira/browse/SOLR-2002
>             Project: Solr
>          Issue Type: Task
>          Components: Build
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2002.patch, SOLR-2002_core_contrib.patch, 
> SOLR-2002setupteardown.patch
>
>
> we are working on improving some functionality in lucene's build/tests, it 
> would be good to improve the solr side to take advantage of it.
> currently its only sorta-kinda integrated and a bit messy.
> i'd like to do some incremental improvements piece-by-piece on this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to