[
https://issues.apache.org/jira/browse/SOLR-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894277#action_12894277
]
Jonathan Rochkind commented on SOLR-1750:
-----------------------------------------
re: naming. If you're someone like me who is becoming fairly familiar with
using solr, but not with the solr code -- then "SolrInfoMBeanHandler" or
"admin/mbean" doesn't mean anything to me, and is kind of confusing. I want to
get info on my indexes and caches-- it would be very non-obvious to me (if i
hadn't read this ticket) that "MBean" has anything to do with this, since I
don't know what an MBean is -- and probably shouldn't have to to use solr
through it's APIs.
So seems to me that a name based on the functions provided (not the underlying
internal implementation) is preferable. But i recognize the namespace conflict
problems, so much stuff in Solr already (some of it deprecated or soon to be
deprecated or removed, some of it not) that it's hard to find a non-conflicting
name.
Even if the underlying class is SolrInfoMBeanHandler, would it be less (or
more) confusing for the path to be /admin/info still? That might be less
confusing, as someone like me would still see /admin/info in the config and
think, aha, that might be what I want. Or the lack of consistency might just be
more confusing in the end.
I don't know what the current SystemInfoHandler does, what's the difference
between that and this new one? There might be hints to naming in that. If the
new one does everything the old one does, perhaps call it NewSystemInfoHandler,
but still register it at /admin/info, with the other one being deprecated? Just
brainstorming. Or rename the other one to OldSystemInfoHandler.
> SolrInfoMBeanHandler - replacement for stats.jsp and registry.jsp
> -----------------------------------------------------------------
>
> Key: SOLR-1750
> URL: https://issues.apache.org/jira/browse/SOLR-1750
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Priority: Trivial
> Fix For: 1.5, 3.1, 4.0
>
> Attachments: SOLR-1750-followup.patch,
> SystemStatsRequestHandler.java, SystemStatsRequestHandler.java,
> SystemStatsRequestHandler.java
>
>
> stats.jsp is cool and all, but suffers from escaping issues, and also is not
> accessible from SolrJ or other standard Solr APIs.
> Here's a request handler that emits everything stats.jsp does.
> For now, it needs to be registered in solrconfig.xml like this:
> {code}
> <requestHandler name="/admin/stats"
> class="solr.SystemStatsRequestHandler" />
> {code}
> But will register this in AdminHandlers automatically before committing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
