[ https://issues.apache.org/jira/browse/SOLR-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Sekiguchi resolved SOLR-2046. ---------------------------------- Assignee: Koji Sekiguchi Fix Version/s: 3.1 4.0 Resolution: Fixed trunk: Committed revision 990160. branch_3x: Committed revision 990162. > add a function to set curl_url in scripts-util > ---------------------------------------------- > > Key: SOLR-2046 > URL: https://issues.apache.org/jira/browse/SOLR-2046 > Project: Solr > Issue Type: Improvement > Components: replication (scripts) > Affects Versions: 1.4.1 > Reporter: Koji Sekiguchi > Assignee: Koji Sekiguchi > Priority: Trivial > Fix For: 3.1, 4.0 > > Attachments: SOLR-2046.patch, SOLR-2046.patch, SOLR-2046.patch, > SOLR-2046.patch > > > abc/abo/commit/optimize/readercycle scripts have the following identical > snippet to set curl_url: > {code} > if [[ -n ${solr_url} ]] > then > curl_url=${solr_url} > else > if [[ -z ${solr_port} ]] > then > echo "Solr port number missing in $confFile or command line." > echo "$USAGE" > exit 1 > fi > # use default hostname if not specified > if [[ -z ${solr_hostname} ]] > then > solr_hostname=localhost > fi > # use default webapp name if not specified > if [[ -z ${webapp_name} ]] > then > webapp_name=solr > fi > curl_url=http://${solr_hostname}:${solr_port}/${webapp_name}/update > fi > {code} > I think it should be moved to scripts-util in order to improve > readability/maintainability. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org