[ 
https://issues.apache.org/jira/browse/LUCENE-2643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909256#action_12909256
 ] 

Simon Willnauer commented on LUCENE-2643:
-----------------------------------------

bq. since its unused, its not obvious that its "wrong" (its correct if you want 
the first code unit difference)

yeah - my interpretation would be its wrong since you use Character.charAt(int) 
with the index of the first code unit. anyway - we should drop for trunk but I 
am not sure if we should for 3.x. I mean this is not that much of a deal anyway.

> StringHelper#stringDifference is wrong about supplementary chars 
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2643
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2643
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.0, 3.0.1, 3.0.2
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>            Priority: Trivial
>             Fix For: 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2643.patch
>
>
> StringHelper#stringDifference does not take supplementary characters into 
> account. Since this is not used internally at all we should think about 
> removing it but I guess since it is not too complex we should just or fix it 
> for bwcompat reasons. For released versions we should really fix it since 
> folks might use it though. For trunk we could just drop it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to