[
https://issues.apache.org/jira/browse/LUCENE-2656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912445#action_12912445
]
Michael McCandless commented on LUCENE-2656:
--------------------------------------------
Super -- patch looks great!
> If tests fail, don't report about unclosed resources
> ----------------------------------------------------
>
> Key: LUCENE-2656
> URL: https://issues.apache.org/jira/browse/LUCENE-2656
> Project: Lucene - Java
> Issue Type: Test
> Components: Tests
> Affects Versions: 3.1, 4.0
> Reporter: Robert Muir
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2656.patch
>
>
> LuceneTestCase ensures in afterClass() if you closed all your directories,
> which in turn will check if you have closed any open files.
> This is good, as a test will fail if we have resource leaks.
> But if a test truly fails, this is just confusing, because its usually not
> going to make it to the part of its code where it would call .close()
> So, if any tests fail, I think we should omit this check in afterClass()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
