[ 
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914100#action_12914100
 ] 

Yonik Seeley commented on LUCENE-2649:
--------------------------------------

bq. In this proposal, you could set the CachePopulator on the FieldCache. 

Hmmm, OK, as long as it's possible.

bq. From my point of view, this would make it easier for system with a schema 
(like solr) have consistent results across all calls, rather then making each 
request to the FieldCache need to know about the schema -> parsers -> populator

I think this may make it a lot harder from Solr's point of view.
- it's essentially a static... so it had better not ever be configurable from 
the schema or solrconfig, or it will break multi-core.
- if we ever *did* want to treat fields differently (load some values from a 
DB, etc), we'd want to look that up in the schema - but we don't have a 
reference to the scema in the populator, and we wouldn't want to store one 
there (again, we have multiple schemas).  So... we could essentially create 
custom EntryConfig object and then our custom CachePopulator could delegate to 
the entry config  (and we've essentially re-invented a way to be able to 
specify the populator on a per-field basis).

Are EntryConfig objects stored as keys anywhere?   We need to be very careful 
about memory leaks.

> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
>                 Key: LUCENE-2649
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2649
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, 
> LUCENE-2649-FieldCacheWithBitSet.patch, 
> LUCENE-2649-FieldCacheWithBitSet.patch, 
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.  
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a 
> BitSet for all valid docs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to