I still don't understand how not declaring my tokenStream and reusableTokenStream final can break anything. The methods are there (in my analyzers), and if I risk overriding them somewhere else it's my problem.
What am I missing? To add to your email - I too didn't encounter an analyzer that cannot be reused, yet. Shai On Tue, Oct 19, 2010 at 5:45 PM, Robert Muir <rcm...@gmail.com> wrote: > On Tue, Oct 19, 2010 at 11:21 AM, Robert Muir <rcm...@gmail.com> wrote: > > If someone doesn't override both (e.g. they just override > > tokenStream), then it wouldnt actually use their subclasses code. So > > then the reflection hack from LUCENE-1678 would force the analyzer to > > never re-use, but instead call tokenStream: but this is very bad for > > indexing performance! > > > > Here's a jira issue with an example of how the > tokenstream/reusableTokenStream confusion makes this a real problem in > practice: > > https://issues.apache.org/jira/browse/LUCENE-2279 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > >
