[ 
https://issues.apache.org/jira/browse/SOLR-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12922719#action_12922719
 ] 

Hoss Man commented on SOLR-792:
-------------------------------

{quote}
If we keep it as a separate component, then it puts an additional burden on 
people to remember to configure it, and figure out where to put it - before or 
after the "normal" facet component. And if we add it as a default component 
that is always there, then stuff like debugging output, etc, will list this 
separate component.

I'm not sure I see a benefit to this being a "user visible" component.
{quote}

As far as i'm concerned, all of the things you listed are valuable reasons why 
this *should* be a user visible component -- they are also reasons why i think 
we should try to refactor the existing FacetComponent into separate components:

* Ability to discreetly enable/disable them by removing them from the 
"components" list (ie: maybe you need facet.query and facet.range but you don't 
want facet.field and facet.pivot to be available because of the performance 
impacts)
* ability to see distinct timing data from each of them independently

..refactoring the existing component should be a separate Jira, but since this 
work was already done to keep the pivot code isolated, combining it now seems 
like a bad idea (unless i'm the only person who things these should *all* be 
distinct, user visible, components)

> Pivot (ie: Decision Tree) Faceting Component
> --------------------------------------------
>
>                 Key: SOLR-792
>                 URL: https://issues.apache.org/jira/browse/SOLR-792
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Erik Hatcher
>            Assignee: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-792-as-helper-class.patch, 
> SOLR-792-PivotFaceting.patch, SOLR-792-PivotFaceting.patch, 
> SOLR-792-PivotFaceting.patch, SOLR-792-PivotFaceting.patch, 
> SOLR-792-raw-type.patch, SOLR-792.patch, SOLR-792.patch, SOLR-792.patch, 
> SOLR-792.patch, SOLR-792.patch, SOLR-792.patch
>
>
> A component to do multi-level faceting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to