[ 
https://issues.apache.org/jira/browse/SOLR-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923956#action_12923956
 ] 

Robert Muir commented on SOLR-2187:
-----------------------------------

{quote}
What do you think should be the behavior if setting it fails? Should we fail 
completely (i.e. let the exception percolate up) or should we catch it, log it 
and still provide the MMapDirectory, just w/o the unmap. Seems like, in this 
case, we should just log it, but others are often of the opinion that we should 
fail for these kinds of things.
{quote}

well you can check the static boolean (MMapDirectory.UNMAP_SUPPORTED) yourself, 
when initializing the factory. 
then you could throw an exception if someone tries to enable the option, but 
the underlying jvm doesnt support it.

in practice i think you could enable the option in the config xml by 
example/default... because this works on all major jvms: Sun, IBM, Oracle 
JRockit, etc.

It won't work on apache harmony for example, and probably other jvms, but does 
Solr even work at all on those anyway?


> Provide more DirectoryFactory implementations for the various different 
> Directories
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-2187
>                 URL: https://issues.apache.org/jira/browse/SOLR-2187
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: SOLR-2187.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to