Oh excellent. So let's fail the build if so?
Mike On Mon, Oct 25, 2010 at 6:05 AM, Uwe Schindler <u...@thetaphi.de> wrote: > It has, it already tracks all nocommits and displays them in a list (seems > to be currently broken). You can also fail the build. > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: u...@thetaphi.de > > >> -----Original Message----- >> From: Michael McCandless [mailto:luc...@mikemccandless.com] >> Sent: Monday, October 25, 2010 11:19 AM >> To: dev@lucene.apache.org >> Subject: Re: nocommit committed in SolrCore.java >> >> On Mon, Oct 25, 2010 at 2:12 AM, Chris Hostetter >> <hossman_luc...@fucit.org> wrote: >> > >> > : Now we are nocommit-free on trunk & 3.x. >> > >> > FWIW: we can make hudson fail the build if "nocommit" is found >> > anywhere in the source. >> > >> > Just an idea if people are intersted. >> >> +1! >> >> I can do this easily w/ Python... but does hudson have something builtin > to do >> things like this already? >> >> Or we can make it a real unit test, which crawls the sources if they are >> available, and fails if it finds a nocommit. This way we'd see the > failure before >> committing... >> >> Mike >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional >> commands, e-mail: dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
