[ 
https://issues.apache.org/jira/browse/LUCENE-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-2732:
----------------------------------

    Attachment: LUCENE-2732.patch

Patch that fixes XML parsing, to apply first move the hyphenation.dtd to the 
src/resource/ folder.

This patch also removed the hardcoded DTD from the parser and moves it to the 
resources folder (loaded by classloader). Solr is fixed to use the InputSource 
API, but it shozuld really use an URL, so ResourceLoader in Solr should be 
fixed to also supply URLs like ClassLoader!

> Fix charset problems in XML loading in HyphenationCompoundWordTokenFilter 
> (also Solr's loader from schema)
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2732
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2732
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>             Fix For: 2.9.4, 3.0.3, 3.1, 4.0
>
>         Attachments: LUCENE-2732.patch
>
>
> As said in LUCENE-2731, the handling of XML in 
> HyphenationCompoundWordTokenFilter is broken and breaks XML 1.0 (5th edition) 
> spec totally. You should never supply a Reader to any XML api, unless you 
> have internal character data (e.g. created programmatically). Also you should 
> supply a system id, as resolving external entities does not work. The loader 
> from files is much more broken, it always open the file as a Reader and then 
> passes it to InputSource. Instead it should point filename directly to 
> InputSource.
> This issue will fix it in trunk and use InputSource in Solr, but will still 
> supply the Reader possibility in previous versions (deprecated).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to