[
https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867053#comment-13867053
]
Tomás Fernández Löbbe commented on SOLR-5621:
---------------------------------------------
I'm not saying that Solr duplicated Lucene code or the other way around, I'm
just saying that at this point, the code is duplicated. Lucene can't use Solr
code, but Solr can use Lucene's. Making that happen would not only remove from
Solr part of the code, but it would also improve the testing in both, Lucene
and Solr. Using custom code also causes the need of more custom code (like in
my previous example with the SearcherLifetimeManager). I think that as Lucene
evolves, Solr should keep up to date with Lucene's changes and best practices,
after all, it's the same Apache project, right? I do think these are good
reasons.
> Let Solr use Lucene's SeacherManager
> ------------------------------------
>
> Key: SOLR-5621
> URL: https://issues.apache.org/jira/browse/SOLR-5621
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Attachments: SOLR-5621.patch
>
>
> It would be nice if Solr could take advantage of Lucene's SearcherManager and
> get rid of most of the logic related to managing Searchers in SolrCore.
> I've been taking a look at how possible it is to achieve this, and even if I
> haven't finish with the changes (there are some use cases that are still not
> working exactly the same) it looks like it is possible to do. Some things
> still could use a lot of improvement (like the realtime searcher management)
> and some other not yet implemented, like Searchers on deck or
> IndexReaderFactory
> I'm attaching an initial patch (many TODOs yet).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
