[ 
https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867917#comment-13867917
 ] 

Robert Muir commented on LUCENE-5392:
-------------------------------------

I'm running the checks on this patch, it looks good.

A few bugs (the first is just a typo, the other two cross-module links need a 
javadocs-hack)

{noformat}
{@link org.apache.lucene.analysis.CharFilters} -> {@link 
org.apache.lucene.analysis.CharFilter}s,
{@link org.apache.lucene.analysis.standard.StandardAnalyzer} -> <a 
href="{@docRoot}/../analyzers-common/org/apache/lucene/analysis/standard/StandardAnalyzer.html">StandardAnalyzer</a>
{@link org.apache.lucene.analysis.miscellaneous.PerFieldAnalyzerWrapper} -> <a 
href="{@docRoot}/../analyzers-common/org/apache/lucene/analysis/miscellaneous/PerFieldAnalyzerWrapper.html">PerFieldAnalyzerWrapper</a>
{noformat}

I also added a short blurb to MIGRATE.txt in trunk to explain the change. 
Currently it just points them at the package documentation for more details:
{noformat}
+
+## Removed Reader from Tokenizer constructor (LUCENE-5388)
+
+The constructor of Tokenizer no longer takes Reader, as this was a leftover
+from before it was reusable. See the org.apache.lucene.analysis package
+documentation for more details.
{noformat}

I'm running full documentation-lint checks now, when it passes ill commit. 
Thanks Benson!

> Documentation for modified token / analysis pipeline
> ----------------------------------------------------
>
>                 Key: LUCENE-5392
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5392
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 5.0
>            Reporter: Benson Margulies
>
> The changes to the tokenizer and analyzer need to be reflected in the package 
> overview for core analysis.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to