[ 
https://issues.apache.org/jira/browse/LUCENE-5099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876016#comment-13876016
 ] 

Adriano Crestani commented on LUCENE-5099:
------------------------------------------

After some investigation, I reached the conclusion that QueryNodeProcessorImpl 
should never take the decision of detaching the returned processed node from 
its parent. It should be up to the processor implementor logic or to the 
processor user to take that decision. For that reason, I have renamed this JIRA.

Instead, we should add a method to QueryNode so the processor implementor or 
user could detach nodes from their parents.

> QueryNode should have the ability to detach from its node parent
> ----------------------------------------------------------------
>
>                 Key: LUCENE-5099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5099
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/queryparser
>    Affects Versions: 3.6.2, 4.3.1
>            Reporter: Adriano Crestani
>            Assignee: Adriano Crestani
>
> QueryNodeProcessorImpl should always return the root of the tree after 
> processing, so it needs to make the parent is set to null before returning. 
> Otherwise, the previous parent is leaked and never removed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to