[
https://issues.apache.org/jira/browse/LUCENE-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2753:
-------------------------------
Attachment: LUCENE-2753.patch
Patch against 3x:
* Changes listCommits() signature to return a List<IndexCommit>
* DirReader.listCommits() sorts the list in the end.
* Added a test case to TestIndexReader.
* IndexCommit implements Comparable. Removed impl from CommitPoint (which also
removed a redundant duplicate 'gen' member).
I did not implement ReaderCommit to support deletes. Obtaining the lock for
this purpose does not seem the right way to me ... IndexWriter has a
deleteUnusedFiles which the application can use. If the app only does
IR.listCommits, then being able to delete is an advantage, but otherwise it
will need to mess with LockObtainFail exceptions. Not sure it's worth the
efforts.
I believe it is ready to commit. I'll wait a day or two until I commit it. Your
comments are welcome.
> IndexReader.listCommits should return a List and not an abstract Collection
> ---------------------------------------------------------------------------
>
> Key: LUCENE-2753
> URL: https://issues.apache.org/jira/browse/LUCENE-2753
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2753.patch
>
>
> Spinoff from here:
> http://www.mail-archive.com/[email protected]/msg07509.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
