[ 
https://issues.apache.org/jira/browse/SOLR-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882899#comment-13882899
 ] 

Shawn Heisey edited comment on SOLR-5670 at 1/27/14 3:41 PM:
-------------------------------------------------------------

>From a design perspective, I can't claim to know whether this is an acceptable 
>patch or not.  Consistency in configs across multiple users and multiple 
>versions does have some value, which is a very minor argument against this 
>change.

Is there any benchmark data? If docValues provides better performance for 
\_version\_ than indexed when it is used for its intended purpose, it might be 
worth changing the example config ... but people should know that if they *do* 
change the config on this field, they will have to completely reindex.

This patch is functionally identical to the previous one, it just modifies an 
error message.  I didn't check to see what branch Per's patch was created on, 
but it did apply cleanly to branch_4x.  This patch is against that branch.


was (Author: elyograg):
>From a design perspective, I can't claim to know whether this is an acceptable 
>patch or not.  Consistency in configs across multiple users and multiple 
>versions does have some value, which is a very minor argument against this 
>change.

Is there any benchmark data? If docValues provides better performance for 
_version_ than indexed when it is used for its intended purpose, it might be 
worth changing the example config ... but people should know that if they *do* 
change the config on this field, they will have to completely reindex.

This patch is functionally identical to the previous one, it just modifies an 
error message.  I didn't check to see what branch Per's patch was created on, 
but it did apply cleanly to branch_4x.  This patch is against that branch.

> _version_ either indexed OR docvalue
> ------------------------------------
>
>                 Key: SOLR-5670
>                 URL: https://issues.apache.org/jira/browse/SOLR-5670
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>    Affects Versions: 4.7
>            Reporter: Per Steffensen
>            Assignee: Per Steffensen
>              Labels: solr, solrcloud, version
>         Attachments: SOLR-5670.patch, SOLR-5670.patch
>
>
> As far as I can see there is no good reason to require that "_version_" field 
> has to be indexed if it is docvalued. So I guess it will be ok with a rule 
> saying "_version_ has to be either indexed or docvalue (allowed to be both)".



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to