[
https://issues.apache.org/jira/browse/SOLR-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitaliy Zhovtyuk updated SOLR-5589:
-----------------------------------
Attachment: SOLR-5589.patch
Master and slave considered as disabled in 3cases: not configured master/slave,
configured but missing "enable" parameter on master/slave, explicitly defined
enable=false on master/slave.
In all 3cases when master and slave disabled only default value for
non-configured ReplicationHandler is master and replicateOnCommit.
Since we disable replication in this case (not configured master and slave or
omitted enable config) replication stops working.
This is the reason of those tests failure (master and replication expected when
handler configuration omitted).
I propose to disable replication only in case of explicitly defined
enable=false for master and slave.
Attached patch illustrate the idea.
> Disabled replication in config is ignored
> -----------------------------------------
>
> Key: SOLR-5589
> URL: https://issues.apache.org/jira/browse/SOLR-5589
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 4.5
> Reporter: alexey
> Assignee: Shalin Shekhar Mangar
> Fix For: 4.7
>
> Attachments: SOLR-5589.patch, SOLR-5589.patch, SOLR-5589.patch,
> SOLR-5589.patch
>
>
> When replication on master node is explicitly disabled in config, it is still
> enabled after start. This is because when both master and slave
> configurations are written with enabled=false, replication handler considers
> this node is a master and enables it. With proposed patch handler will
> consider this as master node but will disable replication on startup if it is
> disabled in config (equivalent to disablereplication command).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
