[
https://issues.apache.org/jira/browse/SOLR-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884259#comment-13884259
]
alexey commented on SOLR-5589:
------------------------------
Vitaly,
ok it looks like my initial patch was not comlete. Thank you for working on it.
What if <enable> attribute will be optional and will be used only for explicit
disabling when someone need it? Missing <enable> attribute is treated as True
to provide backwards compatibility.
Ideally the following config to be enough to say that we want replication but
disabled at startup.
<requestHandler name="/replication" class="solr.ReplicationHandler" >
<lst name="master">
<str name="enable">false</str>
<str name="replicateAfter">commit</str>
<str name="confFiles">schema.xml</str>
</lst>
</requestHandler>
So the patch could be changed to something like
if(disabledExplicitly(slave) || disabledExplicitly(master)){
replicationEnabled.set(false);
}
> Disabled replication in config is ignored
> -----------------------------------------
>
> Key: SOLR-5589
> URL: https://issues.apache.org/jira/browse/SOLR-5589
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Affects Versions: 4.5
> Reporter: alexey
> Assignee: Shalin Shekhar Mangar
> Fix For: 4.7
>
> Attachments: SOLR-5589.patch, SOLR-5589.patch, SOLR-5589.patch,
> SOLR-5589.patch
>
>
> When replication on master node is explicitly disabled in config, it is still
> enabled after start. This is because when both master and slave
> configurations are written with enabled=false, replication handler considers
> this node is a master and enables it. With proposed patch handler will
> consider this as master node but will disable replication on startup if it is
> disabled in config (equivalent to disablereplication command).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
