[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885775#comment-13885775
]
Steve Rowe commented on LUCENE-5353:
------------------------------------
{quote}
bq. I agree in theory, but this class has other options which should get the
same treatment, and presumably other filters have the same issue. Can you make
another issue to do across-the-board cleanup?
that is fine for existing stuff but new stuff should not got down that path. We
can have one large ctor for all the other options that are rare no need for
ton's of permutations.
{quote}
I disagree - I don't want to commit a half-assed fix here. I think the way to
go is make another issue to do across-the-board cleanup, on trunk, and
deprecate the existing mess on branch_4x.
Your way makes it harder to use this option via a mile-long ctor, and the class
is still not immutable. Extra user effort for zero benefit. No thanks.
{quote}
bq. The public static is the default value, so it needs to be there... why not
keep it public? Would renaming it to "default"<whatever> do it for you?
just make it a public static final String and call toCharArray on it no need to
expose the impl details that this is a char array.
{quote}
I agree, it already is public static final, and it should be a String.
> ShingleFilter should have a way to specify FILLER_TOKEN
> -------------------------------------------------------
>
> Key: LUCENE-5353
> URL: https://issues.apache.org/jira/browse/LUCENE-5353
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.6
> Reporter: Simon Willnauer
> Assignee: Steve Rowe
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5353.patch, LUCENE-5353.patch, LUCENE-5353.patch
>
>
> Today we have no choice that if pos_inc is > 1 there will be a `_` inserted
> in between the tokens. We should have the ability to change this character
> and the char[] that holds it should not be public static since it's mutable.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
