[
https://issues.apache.org/jira/browse/LUCENE-5353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated LUCENE-5353:
-------------------------------
Attachment: LUCENE-5353.patch
bq. Ah you don't need to I mean we can clean this one up in a different issue
but I don't think we need to do all TokenFilters just because we wanna fix this
one..
Makes sense, I'll create an issue for fixing all of them, and attach a patch
for just ShingleFilter. Relatedly, I see Chris Male made
{{ShingleAnalyzerWrapper}} immutable in LUCENE-3434.
Attaching a hopefully final patch with these changes:
# {{char[] FILLER_TOKEN}} -> {{String DEFAULT_FILLER_TOKEN}}
# {{setTokenFiller()}} -> {{setFillerToken()}} (I blame my latent dyslexia for
not noticing this one sooner...)
# {{TOKEN_SEPARATOR}} -> {{DEFAULT_TOKEN_SEPARATOR}} (it was the only {{public
static final}} default without the {{DEFAULT_}} prefix)
# Added fillerToken support to {{ShingleAnalyzerWrapper}}/{{Test}}
> ShingleFilter should have a way to specify FILLER_TOKEN
> -------------------------------------------------------
>
> Key: LUCENE-5353
> URL: https://issues.apache.org/jira/browse/LUCENE-5353
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Affects Versions: 4.6
> Reporter: Simon Willnauer
> Assignee: Steve Rowe
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5353.patch, LUCENE-5353.patch, LUCENE-5353.patch,
> LUCENE-5353.patch
>
>
> Today we have no choice that if pos_inc is > 1 there will be a `_` inserted
> in between the tokens. We should have the ability to change this character
> and the char[] that holds it should not be public static since it's mutable.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
