[ 
https://issues.apache.org/jira/browse/SOLR-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tomás Fernández Löbbe updated SOLR-5621:
----------------------------------------

    Attachment: SOLR-5621.patch

I'm uploading a patch with some changes. I added a test for 
SolrSearcherFacrtory. There are still some use cases missing:
newReaderCreator: My understanding is that, during a core reload, Solr uses the 
reader from the old core to warm the first searcher of the new core. Right now 
I'm not doing that after these changes.
searchersOnDeck/maxWarmingSearchers is also not implemented. Right now there 
can be 0 or 1 searcher warming, but no more than that. All searchers except for 
the first one created are warmed inside the SolrSearcherFactory, and 
immediately after that "registered". the SearcherManager won't try to create 
more than one Searcher at a time.
IndexReaderFactory is not implemented

There are still some tests failing intermittently, I'm looking into that. 
I think I should be able to do a much better job managing the "realtime 
searcher" vs the regular searcher, but I didn't focus on that yet. 
I'm using this github repository: https://github.com/tflobbe/lucene-solr


> Let Solr use Lucene's SeacherManager
> ------------------------------------
>
>                 Key: SOLR-5621
>                 URL: https://issues.apache.org/jira/browse/SOLR-5621
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Tomás Fernández Löbbe
>             Fix For: 5.0
>
>         Attachments: SOLR-5621.patch, SOLR-5621.patch
>
>
> It would be nice if Solr could take advantage of Lucene's SearcherManager and 
> get rid of most of the logic related to managing Searchers in SolrCore. 
> I've been taking a look at how possible it is to achieve this, and even if I 
> haven't finish with the changes (there are some use cases that are still not 
> working exactly the same) it looks like it is possible to do.  Some things 
> still could use a lot  of improvement (like the realtime searcher management) 
> and some other not yet implemented, like Searchers on deck or 
> IndexReaderFactory
> I'm attaching an initial patch (many TODOs yet). 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to