[ 
https://issues.apache.org/jira/browse/SOLR-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Davids updated SOLR-3854:
-------------------------------

    Attachment: SOLR-3854.patch

Update the patch with the following changes:

# hostProtocol has been changed to hostUrlScheme
# No longer need to specify the "urlScheme" on the HttpShardHandlerFactory. The 
scheme is only stripped/replaced if that value is specifically configured and 
SolrCloud passes the configured base_url value with the proper http/https 
scheme.
# Added a test that runs the CloudSolrServerTest in SSL mode

There appears to be a few other places that is still hard-coding a scheme:

{code:title=SolrZkClient.getBaseUrlForNodeName(nodeName)}
...
return "http://"; + hostAndPort + (path.isEmpty() ? "" : ("/" + path));
{code}

getBaseUrlForNodeName is exclusively used by the OverseerCollectionProcessor.

{code:title=CloudSolrServer.request(request)}
...
if (request.getPath().equals("/admin/collections")
        || request.getPath().equals("/admin/cores")) {
      Set<String> liveNodes = clusterState.getLiveNodes();
      for (String liveNode : liveNodes) {
        int splitPointBetweenHostPortAndContext = liveNode.indexOf("_");
        theUrlList.add("http://";
            + liveNode.substring(0, splitPointBetweenHostPortAndContext)
            + "/"
            + URLDecoder.decode(liveNode, "UTF-8").substring(
                splitPointBetweenHostPortAndContext + 1));
      }
    }
...
{code}

Not positive how those two instances should be handled as it isn't dealing with 
a specific core, but the server in general.

> SolrCloud does not work with https
> ----------------------------------
>
>                 Key: SOLR-3854
>                 URL: https://issues.apache.org/jira/browse/SOLR-3854
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Sami Siren
>            Assignee: Mark Miller
>             Fix For: 5.0, 4.7
>
>         Attachments: SOLR-3854.patch, SOLR-3854.patch, SOLR-3854.patch, 
> SOLR-3854.patch, SOLR-3854.patch, SOLR-3854.patch
>
>
> There are a few places in current codebase that assume http is used. This 
> prevents using https when running solr in cloud mode.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to