[
https://issues.apache.org/jira/browse/LUCENE-5431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5431:
-------------------------------
Attachment: LUCENE-5431.patch
Modified FSDirectory/FSLockFactory.toString() to use getSimpleName. They
document it's for debugging purposes, so apps shouldn't rely on it. I also
added TestFilterDirectory to make sure we override all Directory methods (but
it allows defining some that we're OK with not overriding), so we don't forget
to override important methods like getLockID() in the future.
I think it's ready.
> Add FSLockFactory.toString()
> ----------------------------
>
> Key: LUCENE-5431
> URL: https://issues.apache.org/jira/browse/LUCENE-5431
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Reporter: Shai Erera
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-5431.patch, LUCENE-5431.patch
>
>
> FSLockFactory doesn't override toString, which causes Dir.toString() to print
> the class.name@instance. I think it would be better if it printed e.g. the
> lockDir.
> I added it but TestCrashCausesCorruptIndex failed because it declares a
> Directory which doesn't override getLockID(), which returns toString(). I
> changed that Directory to extend FilterDirectory, and fixed FilterDirectory
> to override getLockID() to call in.getLockID().
> Will attach a patch shortly.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
