[
https://issues.apache.org/jira/browse/SOLR-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890977#comment-13890977
]
Erik Hatcher commented on SOLR-3854:
------------------------------------
Steve - is your latest patch for trunk or branch_4x or does it matter?
Seems to apply ok on trunks, but with offsets:
{code}
$ patch -p0 < SOLR-3854.patch
patching file
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
patching file solr/core/src/java/org/apache/solr/cloud/ElectionContext.java
patching file
solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
Hunk #1 succeeded at 511 (offset 24 lines).
Hunk #2 succeeded at 766 (offset 24 lines).
Hunk #3 succeeded at 1511 (offset 24 lines).
Hunk #4 succeeded at 1646 (offset 24 lines).
Hunk #5 succeeded at 1743 (offset 24 lines).
patching file solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
patching file solr/core/src/java/org/apache/solr/cloud/ZkController.java
patching file solr/core/src/java/org/apache/solr/core/ConfigSolr.java
patching file solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java
patching file solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java
patching file solr/core/src/java/org/apache/solr/core/ZkContainer.java
patching file
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java
patching file
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
patching file
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
patching file solr/core/src/java/org/apache/solr/update/PeerSync.java
patching file
solr/core/src/test/org/apache/solr/cloud/BasicDistributedSSLZkTest.java
patching file
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
patching file solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java
patching file solr/core/src/test/org/apache/solr/core/TestSolrXml.java
patching file solr/core/src/test-files/solr/solr-50-all.xml
patching file solr/core/src/test-files/solr/solr.xml
patching file solr/solrj/src/java/org/apache/solr/common/util/URLUtil.java
patching file
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrServerSSLTest.java
patching file solr/solrj/src/test/org/apache/solr/common/util/URLUtilTest.java
patching file solr/solrj/src/test-files/solrj/solr/solr.xml
patching file
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
patching file
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
{code}
but reports some failures on branch_4x:
{code}
$ patch -p0 < SOLR-3854.patch
patching file
solr/core/src/java/org/apache/solr/client/solrj/embedded/JettySolrRunner.java
patching file solr/core/src/java/org/apache/solr/cloud/ElectionContext.java
patching file
solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
Hunk #1 succeeded at 511 (offset 24 lines).
Hunk #2 succeeded at 766 (offset 24 lines).
Hunk #3 succeeded at 1511 (offset 24 lines).
Hunk #4 succeeded at 1646 (offset 24 lines).
Hunk #5 succeeded at 1743 (offset 24 lines).
patching file solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
patching file solr/core/src/java/org/apache/solr/cloud/ZkController.java
patching file solr/core/src/java/org/apache/solr/core/ConfigSolr.java
Hunk #1 succeeded at 135 (offset 4 lines).
Hunk #2 succeeded at 239 (offset 4 lines).
patching file solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java
patching file solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java
Hunk #1 succeeded at 149 (offset -2 lines).
patching file solr/core/src/java/org/apache/solr/core/ZkContainer.java
Hunk #1 FAILED at 65.
Hunk #2 succeeded at 155 (offset 21 lines).
1 out of 2 hunks FAILED -- saving rejects to file
solr/core/src/java/org/apache/solr/core/ZkContainer.java.rej
patching file
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java
patching file
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
patching file
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
patching file solr/core/src/java/org/apache/solr/update/PeerSync.java
patching file
solr/core/src/test/org/apache/solr/cloud/BasicDistributedSSLZkTest.java
patching file
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
patching file solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java
patching file solr/core/src/test/org/apache/solr/core/TestSolrXml.java
patching file solr/core/src/test-files/solr/solr-50-all.xml
patching file solr/core/src/test-files/solr/solr.xml
patching file solr/solrj/src/java/org/apache/solr/common/util/URLUtil.java
patching file
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrServerSSLTest.java
patching file solr/solrj/src/test/org/apache/solr/common/util/URLUtilTest.java
patching file solr/solrj/src/test-files/solrj/solr/solr.xml
patching file
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java
patching file
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java
{code}
Am I doing something wrong or in the wrong place? I'm admittedly little
rusty/unfamiliar with this fast moving (SolrCloud distrib testing) area lately.
> SolrCloud does not work with https
> ----------------------------------
>
> Key: SOLR-3854
> URL: https://issues.apache.org/jira/browse/SOLR-3854
> Project: Solr
> Issue Type: Bug
> Reporter: Sami Siren
> Assignee: Mark Miller
> Fix For: 5.0, 4.7
>
> Attachments: SOLR-3854.patch, SOLR-3854.patch, SOLR-3854.patch,
> SOLR-3854.patch, SOLR-3854.patch, SOLR-3854.patch
>
>
> There are a few places in current codebase that assume http is used. This
> prevents using https when running solr in cloud mode.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
