[ 
https://issues.apache.org/jira/browse/LUCENE-5436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893684#comment-13893684
 ] 

Simon Willnauer commented on LUCENE-5436:
-----------------------------------------

bq. Hmm, sneaky. So we are adding best-effort catching of this mis-use?
yeah this is nothing else than preventing the manager from going into an 
infinite loop.

bq. Instead of isClosed can we add protected getRefCount? That's just more 
consistent with the current abstract methods we already have?
yeah I think that is a better name.

> RefrenceManager#accquire can result in infinite loop if manager resource is 
> abused outside of the manager
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5436
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5436
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 4.6.1, 5.0, 4.7
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.7
>
>         Attachments: LUCENE-5436.patch
>
>
> I think I found a bug that can cause the ReferenceManager to stick in an 
> infinite loop if the managed reference is decremented outside of the manager 
> without a corresponding increment. I think this is pretty bad since the 
> debugging of this is a mess and we should rather throw ISE instead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to