[
https://issues.apache.org/jira/browse/SOLR-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13893715#comment-13893715
]
Hoss Man commented on SOLR-5423:
--------------------------------
Hey Arun, some comments about your patch:
* please generate patches against he entire code base so they are easier to
apply & review: https://wiki.apache.org/solr/HowToContribute#Generating_a_patch
* can you explain what's going on with the getOriginalNameForFunctionField
function in your patch? ... it seems extremely sketchy. if the problem is just
that ValueSourceAugmenter's "getName" doesn't match the actual fieldname the
transformer puts in the modified documents, we should fix that in
ValueSourceAugmenter
* in general, the amount of instanceof checking going on in your patch seems
really brittle, and i'm not exactly sure why it's neccessary. As I understand
it the CSVResponseWriter already loops over all of the field names in the
documents to be returned to get the list of column names it should output -- so
as long as the transformer logic is applied before that, then won't the field
names be picked up automatically?
independent of any of the above questions about this patch, we shouldn't move
forward with committing support for transformers to the csv repsonse writer w/o
having some tests that prove it works.
> CSV output doesn't include function field
> -----------------------------------------
>
> Key: SOLR-5423
> URL: https://issues.apache.org/jira/browse/SOLR-5423
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.4
> Reporter: James Wilson
> Attachments: CSVResponseWriter.java.patch
>
>
> Given a schema with
> <field name="price" type="float" indexed="true" stored="true"/>
> <field name='numpages' type='int' indexed='true' stored='true'/>
>
> the following query returns no rows:
> http://localhost:8983/solr/collection1/select?q=*%3A*&rows=30&fl=div(price%2Cnumpages)&wt=csv&indent=true
> However, setting wt=json or wt=xml, it works.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
