[ 
https://issues.apache.org/jira/browse/LUCENE-5437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894500#comment-13894500
 ] 

Nik Everett commented on LUCENE-5437:
-------------------------------------

I thought about that but my instinct was that duplicating with the keyword 
attribute would add overhead in the case where there aren't characters to fold 
which is by far the more common case.  I think you'd also have to make 
supporting the keyword attribute optional so it wouldn't break backwards 
compatibility.  I figured optionally supporting the keyword attribute would be 
about the same amount of work/code as only duplicating when required so I went 
that way.  I went with adding the extra class and moving the real 
implementation to an absract base class more out of desire to be minimally 
invasive to the original then anything technical.

> ASCIIFoldingFilter that emits both unfolded and folded tokens
> -------------------------------------------------------------
>
>                 Key: LUCENE-5437
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5437
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Nik Everett
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-5437.patch
>
>
> I've found myself wanting an ASCIIFoldingFilter that emits both the folded 
> tokens and the original, unfolded tokens.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to