[
https://issues.apache.org/jira/browse/SOLR-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897312#comment-13897312
]
Mark Miller commented on SOLR-5649:
-----------------------------------
bq. "clientConnected" doesn't seem to be read, can be eliminated
Yup, a relica from original code.
bq. "state" is a private volatile variable, but only used in one function –
seems unlikely private volatile is what is wanted
Yeah, there used to be a getState method that we inherited but it is gone now.
bq. A comment explaining why disconnected() is not called in the case of
Expired would be helpful (Expired means we have already waited the timeout
period so we want to reject updates right away)
The current comment already says:
{quote} // we don't call disconnected because there
// is no need to start the timer - if we are expired
// likelyExpired can just be set to true{quote}
> Small ConnectionManager improvements
> ------------------------------------
>
> Key: SOLR-5649
> URL: https://issues.apache.org/jira/browse/SOLR-5649
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.6.1
> Reporter: Gregory Chanan
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 5.0, 4.7
>
>
> I was just looking through the ConnectionManager and want to jot these down
> before I forget them. I'm happy to make a patch if someone thinks it's
> valuable as well.
> - "clientConnected" doesn't seem to be read, can be eliminated
> - "state" is a private volatile variable, but only used in one function --
> seems unlikely private volatile is what is wanted
> - A comment explaining why disconnected() is not called in the case of
> Expired would be helpful (Expired means we have already waited the timeout
> period so we want to reject updates right away)
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
