[ 
https://issues.apache.org/jira/browse/LUCENE-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-5463:
---------------------------------

    Attachment: LUCENE-5463.patch

Here is a new patch iterating on Robert's:
 - RamUsageEstimator, FieldCache.CacheEntry, CachingWrapperFilter and 
MemoryIndex (lucene/memory) are excluded from the forbidden checks on 
RamUsageEstimator
 - CachedOrdinalsReader (lucene/facets) and the suggesters (lucene/suggest) 
have been fixed to use less costly memory estimations.

I think it would be nice to have memory usage estimations on filters in order 
to be able to remove CachingWrapperFilter from the exclusions but since this 
would be a large change, I'd rather do it as a separate issue.

> Make RamUsageEstimator.(human)sizeOf(Object) a forbidden API
> ------------------------------------------------------------
>
>                 Key: LUCENE-5463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5463
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>         Attachments: LUCENE-5463.patch, LUCENE-5463.patch
>
>
> We have had a few issues with {{RamUsageEstimator}} recently so I think we 
> should consider making the {{sizeOf(Object)}} and {{humanSizeOf(Object)}} 
> methods forbidden under src/java (however still allowed for tests as it is 
> handy to check the size computations which are done "manually"). However, 
> {{sizeOf(byte[])}}, {{shallowSizeOf(Class)}}, etc. remain useful so I think 
> we should keep them allowed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to