[
https://issues.apache.org/jira/browse/LUCENE-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911791#comment-13911791
]
Robert Muir commented on LUCENE-5470:
-------------------------------------
btw, i do think we want to consolidate this. But I'm not sure QueryBuilder is
the appropriate place (in general thats a very very simple subclass and doesnt
handle these types of queries).
Personally i was htinking more along the lines of making the default
implementation in QueryParserBase (analyzeMultitermTerm) a simple static method
available somewhere that parsers can use? e.g. it just takes an Analyzer, a
field name, and some text and ensures there is only one token and returns the
term.
> Refactoring multiterm analysis
> ------------------------------
>
> Key: LUCENE-5470
> URL: https://issues.apache.org/jira/browse/LUCENE-5470
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/queryparser
> Affects Versions: 5.0
> Reporter: Tim Allison
> Priority: Minor
> Attachments: LUCENE-5470.patch
>
>
> There are currently three methods to analyze multiterms in Lucene and Solr:
> 1) QueryParserBase
> 2) AnalyzingQueryParser
> 3) TextField (Solr)
> The code in QueryParserBase and in TextField do not consume the tokenstream
> if more than one token is generated by the analyzer. (Admittedly, thanks to
> the magic of MultitermAwareComponents in Solr, this type of exception
> probably never happens and the unconsumed stream problem is probably
> non-existent in Solr.)
> I propose consolidating the multiterm analysis code into one place:
> QueryBuilder in Lucene core.
> This is part of a refactoring that will also help reduce duplication of code
> with LUCENE-5205.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
