[
https://issues.apache.org/jira/browse/SOLR-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913696#comment-13913696
]
Mark Miller commented on SOLR-5775:
-----------------------------------
Anyone following - reporting your failing tests would be useful.
I'm certainly open to @BadApple depending on the test.
Some of them need to be fixed instead - the loss of coverage is easily worse
than infrequent failing tests that can probably be addressed.
Some of them, like the ShardSplitTest that is usually infrequent these days,
should probably print out the JIRA issue in the fail.
I'm happy to discuss each of them and take some course of action individually.
If people want to contribute towards that great, and thanks to everyone that
has so far, but I can't allow wholesale disabling of tests.
The ones Robert was looking at were not these infrequent fails though - they
were more common fails due to both the performance of SSL and a bug in
disabling it for tests. They are not really in the same category and those
issues have working workarounds now.
> Disable constantly failing solr tests
> -------------------------------------
>
> Key: SOLR-5775
> URL: https://issues.apache.org/jira/browse/SOLR-5775
> Project: Solr
> Issue Type: Bug
> Components: Build
> Reporter: Robert Muir
>
> Currently, solr tests are failing 90%+ of the time. We've been through this
> before many times, the argument is always that someone is looking at the
> failures and knows which ones are bad.
> This argument is a lie. Nobody is watching these failures, or
> DistributedQueryComponentOptimizationTest would not have failed repeatedly
> for two straight days when the fix was trivial (I fixed this last night:
> http://svn.apache.org/r1571930)
> Its frustrating to me as a committer, solr tests *NEVER* pass on my machine,
> no matter how many times I try. How can i possibly commit something without
> knowing i am making the situation even worse?
> This is all a big problem for developers, release managers, even users of the
> project. The test suite should pass.
> The old argument that "solr tests are allowed to fail" is no longer valid. I
> will disable all constantly failing tests.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
