[
https://issues.apache.org/jira/browse/LUCENE-5493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-5493:
--------------------------------
Attachment: LUCENE-5493-poc.patch
Here is a very simple proof of concept patch.
I made a SortSorter (extends existing Sorter api and takes o.a.l.s.Sort),
removed NumericDocValuesSorter, and replaced it with this more general
Sort-Sorter in all tests and they pass.
So my next step would be to remove public apis like Sorter/DocMap and make that
all internal. SortingMP and EarlyTerminatingSortingCollector would just take
Sort directly.
BlockJoinSorter needs to be cutover to a regular comparator. And in suggest/
there is a custom comparator... that i think doesnt need to be custom and is
just sorting on a dv field.
> Rename Sorter, NumericDocValuesSorter, and fix javadocs
> -------------------------------------------------------
>
> Key: LUCENE-5493
> URL: https://issues.apache.org/jira/browse/LUCENE-5493
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-5493-poc.patch
>
>
> Its not clear to users that these are for this super-expert thing of
> pre-sorting the index. From the names and documentation they think they
> should use them instead of Sort/SortField.
> These need to be renamed or, even better, the API fixed so they aren't public
> classes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
