[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925160#comment-13925160
]
Shai Erera commented on LUCENE-5476:
------------------------------------
bq. Asserting seems redundant, but is that not the point in unit-tests?
The problem is when those false alarms cause noise. The previous sampling tests
had a mechanism to reduce the noise as much as possible, but they didn't
eliminate it. For example, the test was run few times, each time w/ increasing
sample until it gave up and failed. At which point someone had to inspect the
log and determine that this is a false positive. Since you expect at most 5
categories, and any number between 1-5 is fair game, I prefer not to assert on
#categories at all. If you really want to assert something, then make sure {{0
< #categories <= 5}}?
> Facet sampling
> --------------
>
> Key: LUCENE-5476
> URL: https://issues.apache.org/jira/browse/LUCENE-5476
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Rob Audenaerde
> Attachments: LUCENE-5476.patch, LUCENE-5476.patch, LUCENE-5476.patch,
> LUCENE-5476.patch, LUCENE-5476.patch, LUCENE-5476.patch, LUCENE-5476.patch,
> SamplingComparison_SamplingFacetsCollector.java, SamplingFacetsCollector.java
>
>
> With LUCENE-5339 facet sampling disappeared.
> When trying to display facet counts on large datasets (>10M documents)
> counting facets is rather expensive, as all the hits are collected and
> processed.
> Sampling greatly reduced this and thus provided a nice speedup. Could it be
> brought back?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
