[
https://issues.apache.org/jira/browse/LUCENE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933505#action_12933505
]
Uwe Schindler edited comment on LUCENE-2694 at 11/18/10 1:10 PM:
-----------------------------------------------------------------
Havent looked closely into the patch (still need to understand the whole
thing), just some comments from attribute policeman in general:
- The TermStateAttributeImpl.copyTo should throw ClassCastEx if attributes are
not conform (compare other impls), so the if statement should not be there.
AttributeSource takes care of copying. This is not used, but for completeness.
- the convenience addClause() method in abstract base class should be final!
Else you could incorrectly override the wrong one. We already have code
duplication in your patch because of this. When you make it final you will see!
- why is the attribute using a SetOnce? Attributes generally should be
modifiable multiple times. Now you have to call clear() first. This may change
in future when we have set-once attributes, but for now that violates the
contract :-)
- Is the docFreq no already part of the state so TermCollectingRewrite does not
need to expose it separately?
- What happens in the term collectors when the same term with different states
are merged in the PQ/TermsHash/...?
was (Author: thetaphi):
Havent looked closely into the patch (still need to understand the whole
thing), just some comments from attribute policeman in general:
- The TermStateAttributeImpl.copyTo should throw ClassCastEx if attributes are
not conform (compare other impls), so the if statement should not be there.
AttributeSource takes care of copying. This is not used, ut for completeness.
- the convenience addClause() method in abstract base class should be final!
Else you could incorrectly override the wrong one.
- why is the attribute using a SetOnce? Attributes generally should be
modifiable multiple times. Now you have to call clear() first. This may change
in future when we have set-once attributes, but for now that violates the
contract :-)
- Is the docFreq no already part of the state so TermCollectingRewrite does not
need to expose it separately?
- What happens in the term collectors when the same term with different states
are merged in the PQ/TermsHash/...?
> MTQ rewrite + weight/scorer init should be single pass
> ------------------------------------------------------
>
> Key: LUCENE-2694
> URL: https://issues.apache.org/jira/browse/LUCENE-2694
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.0
>
> Attachments: LUCENE-2694.patch
>
>
> Spinoff of LUCENE-2690 (see the hacked patch on that issue)...
> Once we fix MTQ rewrite to be per-segment, we should take it further and make
> weight/scorer init also run in the same single pass as rewrite.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
