[ https://issues.apache.org/jira/browse/LUCENE-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925713#comment-13925713 ]
Robert Muir commented on LUCENE-5487: ------------------------------------- {quote} I think this (Weight.scorer) is an expert enough API that we can fix it in 4.8 as well? {quote} Definitely, I havent had a chance to review the patch but this seems good to do. > Can we separate "top scorer" from "sub scorer"? > ----------------------------------------------- > > Key: LUCENE-5487 > URL: https://issues.apache.org/jira/browse/LUCENE-5487 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 4.8, 5.0 > > Attachments: LUCENE-5487.patch, LUCENE-5487.patch, LUCENE-5487.patch > > > This is just an exploratory patch ... still many nocommits, but I > think it may be promising. > I find the two booleans we pass to Weight.scorer confusing, because > they really only apply to whoever will call score(Collector) (just > IndexSearcher and BooleanScorer). > The params are pointless for the vast majority of scorers, because > very, very few query scorers really need to change how top-scoring is > done, and those scorers can *only* score top-level (throw throw UOE > from nextDoc/advance). It seems like these two types of scorers > should be separately typed. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org