[
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller reopened SOLR-5837:
-------------------------------
I'm going to reopen this. It still bugs me - I think perhaps we should do with
this with test code instead. It's what I was originally thinking - even the
javadoc warnings don't make me feel warm and fuzzy about this. I was chatting
with Robert about it this morning, and that confirmed my feelings that adding
hashCode/equals to these classes just for tests is the wrong move.
> Add missing equals implementation for SolrDocument, SolrInputDocument and
> SolrInputField.
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-5837
> URL: https://issues.apache.org/jira/browse/SOLR-5837
> Project: Solr
> Issue Type: Improvement
> Reporter: Varun Thacker
> Assignee: Mark Miller
> Fix For: 4.8, 5.0
>
> Attachments: SOLR-5837.patch, SOLR-5837.patch
>
>
> While working on SOLR-5265 I tried comparing objects of SolrDocument,
> SolrInputDocument and SolrInputField. These classes did not Override the
> equals implementation.
> The issue will Override equals and hashCode methods to the 3 classes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]