Yes, I was thinking about deprecating the old methods as well. I'll try to add a patch here: https://issues.apache.org/jira/browse/SOLR-2018
Четверг, 13 марта 2014, 12:34 -06:00 от Shawn Heisey <[email protected]>: >On 3/13/2014 6:17 AM, Jack Krupansky wrote: >> The wiki says: “In Solr4.0it will be removed.” >> See: >> https://wiki.apache.org/solr/UpdateXmlMessages >> Unfortunately, the new Solr Reference Guide does not include that note. >> See: >> >> https://cwiki.apache.org/confluence/display/solr/Uploading+Data+with+Index+Handlers >> I would be +1 for having Solr give a 400 error for using it. I mean, >> the app is expecting some specific behavior, and that behavior is not >> going to happen. > >Solr 4.x *DOES* return an error if you use waitFlush with commit. It >broke the php solr package with Solr 4.0 back in 2012. They fixed their >bug a couple of weeks ago: > >https://bugs.php.net/bug.php?id=62332 > >SolrJ still has the parameter in two of the SolrServer#commit methods, >but it is ignored and not sent to Solr. Changing these APIs in 4.x >would break a *LOT* of user software. > >I have thought of a way forward with SolrJ's commit methods: > >* Add commit(boolean waitSearcher), softCommit(), and softCommit(boolean >waitSearcher). >* Deprecate the existing commit methods with two and three booleans. >Remove them in 5.0. > >Thanks, >Shawn > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [email protected] >For additional commands, e-mail: [email protected] >
