[
https://issues.apache.org/jira/browse/SOLR-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935718#comment-13935718
]
Tomás Fernández Löbbe commented on SOLR-5864:
---------------------------------------------
Really the SolrCore (prev) is not being used by the SolrCore constructor, just
the UpdateHandler is needed, and we are already sending it as a parameter.
Maybe instead of renaming the variable it can be removed. I'm attaching a patch
> Remove previous SolrCore as parameter on reload
> -----------------------------------------------
>
> Key: SOLR-5864
> URL: https://issues.apache.org/jira/browse/SOLR-5864
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Priority: Trivial
> Attachments: SOLR-5864.patch, SOLR-5864.patch, SOLR-5864.patch
>
>
> Currently the reload method is reload(SolrResourceLoader resourceLoader,
> SolrCore prev), but all the times it’s called with “prev” being the same as
> “this”:
> core.reload(resourceLoader, core).
> Frankly, I don’t think it even makes sense to call it in other way (it would
> be just to create the first reader with a different core than the one its
> being reloaded?)
> I think we should just remove the SolrCore parameter and let the "reload"
> method always reload the core where it's being called.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
