[ 
https://issues.apache.org/jira/browse/SOLR-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13936212#comment-13936212
 ] 

Ahmet Arslan commented on SOLR-1604:
------------------------------------

Here are some clarification regarding zipped attachments :

Zipped attachments are not meant for source code inclusion but for to be 
consumed as solr plugin. They will never be committed. Mainly because zipped 
version(s) include a duplicate code from lucene code base. Duplicated class is 
org.apache.lucene.queryparser.complexPhrase.ComplexPhraseQueryParser. 
Duplication is done for two reasons :
* To enable fielded queries. this duplicate code changes package name to 
org.apache.lucene.queryparser.classic.ComplexPhraseQueryParser.  Originally 
Somehow this feature forgotten accidentally in LUCENE1468, while committing 
lucene.ComplexPhraseQueryParser. After that commit, package name changed from 
classic to complexPhrase. For this fix it needs to access a field from super 
class. After realizing this, chancing this fields visibility to protected is 
accepted by lazy consensus. This is the 
[patch|https://issues.apache.org/jira/secure/attachment/12513804/LUCENE-1486.patch]
 for this.
* To enable ability change inOrder parameter. In original lucene code inOrder 
parameter is barcoded to true inSpanNearQuery classes. Separate jira for this 
is LUCENE-3758.

By the way, why LUCENE-1486 is re-opened is a mystery. It is not re-opened 
because of unforgotten non-default patch. 

> Wildcards, ORs etc inside Phrase Queries
> ----------------------------------------
>
>                 Key: SOLR-1604
>                 URL: https://issues.apache.org/jira/browse/SOLR-1604
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers, search
>    Affects Versions: 1.4
>            Reporter: Ahmet Arslan
>            Assignee: Erick Erickson
>            Priority: Minor
>         Attachments: ASF.LICENSE.NOT.GRANTED--ComplexPhrase.zip, 
> ComplexPhrase-4.2.1.zip, ComplexPhrase-4.7.zip, ComplexPhrase.zip, 
> ComplexPhrase.zip, ComplexPhrase.zip, ComplexPhrase.zip, ComplexPhrase.zip, 
> ComplexPhrase.zip, ComplexPhraseQueryParser.java, ComplexPhrase_solr_3.4.zip, 
> SOLR-1604-alternative.patch, SOLR-1604.patch, SOLR-1604.patch, 
> SOLR-1604.patch, SOLR-1604.patch
>
>
> Solr Plugin for ComplexPhraseQueryParser (LUCENE-1486) which supports 
> wildcards, ORs, ranges, fuzzies inside phrase queries.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to