[ 
https://issues.apache.org/jira/browse/SOLR-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated SOLR-2292:
-------------------------------

    Fix Version/s:     (was: 4.7)
                   4.8

> Lock down NamedList API, remove inefficent and esoteric methods
> ---------------------------------------------------------------
>
>                 Key: SOLR-2292
>                 URL: https://issues.apache.org/jira/browse/SOLR-2292
>             Project: Solr
>          Issue Type: Task
>            Reporter: Hoss Man
>             Fix For: 4.8
>
>
> Over in SOLR-2288, rmuir made some good points about locking down the 
> NamedList API to protect people...
> {quote}
> I looked at your patch, and personally I think NamedList should really be 
> type-safe.
> If users want to use it in a type-unsafe way, thats fine, but *the container 
> itself shouldn't be List<Object>*.
> {quote}
> ...
> {quote}
> Separately, i just want to say the following about NamedList:
> All uses of this API should really be reviewed. I'm quite aware that it warns 
> you about the fact that its slow for certain operations,
> but in my opinion these *slow operations such as get(String, int) should be 
> deprecated and removed*.
> Any users that are using NamedList in this way, especially in loops, are very 
> likely using the wrong datastructure.
> {quote}
> (emphasis added by me)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to