[
https://issues.apache.org/jira/browse/SOLR-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Davids updated SOLR-5604:
-------------------------------
Attachment: SOLR-5604.patch
Created a patch to prompt a discussion (some tests are broken) with a few
highlights:
* Updated HttpClientUtil to drop all of the setXXX methods, essentially the
only thing remaining is the createClient(SolrParams...)
* HttpClientConfigurer was updated to take a HttpClientBuilder and is properly
setting all of the properties specified in HttpClientUtil
* Created an abstract HttpClientSolrServer which allows for setters (internally
mapping to the properties) then when the first time the getHttpClient() method
is called, the client is created
** This is currently problematic in a few cases like CloudSolrServer or
LBSolrServer because they call getHttpClient() in the constructor. Further work
needs to be done to flesh this one out, generally when you are in this
half-built state there is an init/@PostConstruct method that is called to
finally build the client.
Unfortunately you aren't able to get access to the ConnectionManager when using
the HttpClientBuilder because it returns an 'InternalHttpClient' which doesn't
give you access, it just returns a no-op manager when you call
getConnectionManager();
> Remove deprecations caused by httpclient 4.3.x upgrade
> ------------------------------------------------------
>
> Key: SOLR-5604
> URL: https://issues.apache.org/jira/browse/SOLR-5604
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.7
> Reporter: Shawn Heisey
> Fix For: 4.8, 5.0
>
> Attachments: SOLR-5604-4x-just-lucene.patch, SOLR-5604.patch
>
>
> SOLR-5590 upgraded httpclient in Solr and Lucene to version 4.3.x. This
> version deprecates a LOT of classes and methods, recommending that they all
> be replaced with various methods from the HttpClientBuilder class.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
