[
https://issues.apache.org/jira/browse/SOLR-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937054#comment-13937054
]
Shawn Heisey commented on SOLR-5852:
------------------------------------
[~varunthacker] has proposed that we include the javadoc changes for SOLR-4620
on this issue. Before proceeding with this plan, I would like to hear from
committers with more seniority as to whether this change is a good idea.
My own gut reaction is that we should just stick with the format already
provided by zookeeper, especially since that's the only format that Solr itself
accepts when starting SolrCloud.
The current patch does not allow you to specify a chroot. You could check the
starting character and assume it's a chroot if it starts with a forward slash.
Unless you limited this check to the last argument, you'd need to throw an
exception if there were multiple chroots found and they were not all identical.
When I looked into whether it was possible to have two methods, here's what I
found: Eclipse does allow me to have foo(String,String...) as well as
foo(String...). This surprised me, because Java would likely ignore one of
them. Makes me wonder whether this is an oversight in the JDK, Eclipse, or
both. It wasn't even flagged by a FindBugs run.
> Add CloudSolrServer helper method to connect to a ZK ensemble
> -------------------------------------------------------------
>
> Key: SOLR-5852
> URL: https://issues.apache.org/jira/browse/SOLR-5852
> Project: Solr
> Issue Type: Improvement
> Reporter: Varun Thacker
> Attachments: SOLR-5852.patch, SOLR-5852_FK.patch
>
>
> We should have a CloudSolrServer constructor which takes a list of ZK servers
> to connect to.
> Something Like
> {noformat}
> public CloudSolrServer(String... zkHost);
> {noformat}
> - Document the current constructor better to mention that to connect to a ZK
> ensemble you can pass a comma-delimited list of ZK servers like
> zk1:2181,zk2:2181,zk3:2181
> - Thirdly should getLbServer() and getZKStatereader() be public?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
